-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebUI tests: Fix 'Button is not displayed' exception #4189
Conversation
4232227
to
d529914
Compare
ipatests/test_webui/ui_driver.py
Outdated
|
||
# The small timeout (up to 1 second) allows to prevent exceptions when | ||
# driver attempts to click a button before it is rendered. | ||
WebDriverWait(self.driver, 1, 0.2).until( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest to increase max wait time to 5 seconds - we execute tests in VMs on heavily loaded hosts and I feel that browser can get stuck for second or two.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, agree, fixed.
d529914
to
bcd0c48
Compare
bcd0c48
to
bf365d6
Compare
LGTM. |
bf365d6
to
314ffc0
Compare
Add a small timeout (up to 5 seconds) which allows to prevent exceptions when WebDriver attempts to click a button before it is rendered. Ticket: https://pagure.io/freeipa/issue/8169 Signed-off-by: Serhii Tsymbaliuk <stsymbal@redhat.com>
314ffc0
to
59960aa
Compare
ACK |
master:
|
Add a small timeout (up to 1 second) which allows to prevent exceptions when
WebDriver attempts to click a button before it is rendered.
Ticket: https://pagure.io/freeipa/issue/8169